Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GridDeviceMetadata gate duration property to Mapping type #5656

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Change GridDeviceMetadata gate duration property to Mapping type #5656

merged 4 commits into from
Jul 7, 2022

Conversation

verult
Copy link
Collaborator

@verult verult commented Jun 30, 2022 •
edited
Loading

To make the property immutable. Left constructor arg as Dict.

@MichaelBroughton
cc @maffoo

@verult verult requested a review from MichaelBroughton June 30, 2022 00:51
@verult verult requested review from a team, vtomole and cduck as code owners June 30, 2022 00:51
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 30, 2022
maffoo
maffoo reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest changing the constructor arg too, since any code that currently calls it with a dict will still work.

@verult
Copy link
Collaborator Author

verult commented Jul 6, 2022

Updated

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 7, 2022
@CirqBot CirqBot merged commit 2b9c762 into quantumlib:master Jul 7, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 7, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@verult @rht
Change GridDeviceMetadata gate duration property to Mapping type (qua…
5d7a30b 
…ntumlib#5656)

To make the property immutable. Left constructor arg as `Dict`.

@MichaelBroughton 
cc @maffoo
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@verult
Change GridDeviceMetadata gate duration property to Mapping type (qua…
c4bac0e 
…ntumlib#5656)

To make the property immutable. Left constructor arg as `Dict`.

@MichaelBroughton 
cc @maffoo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maffoo maffoo maffoo left review comments

@dstrain115 dstrain115 dstrain115 approved these changes

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@verult @maffoo @dstrain115 @MichaelBroughton @CirqBot